Remove automake color-tests and parallel-tests because they break solaris and require much newer autotools.

This reverts commit a69368e1.

Actual behaviour was correct on most architectures and breaking that
code would have required a particularly smart compiler.

Timothy B. Terriberry authored 12 years ago and Jean-Marc Valin committed 12 years ago

Including a description of the PVQ encoder and decoder

Also added 3rd clause to "master" COPYING file

See http://www.ietf.org/mail-archive/web/codec/current/msg02833.html
Still more changes to come

This changes the saturation test to ensure that it relies on the
unsigned overflow behaviour (which is allowed) rather than the signed
overflow behaviour (which is undefined).

These were all mostly benign and would at worst result in (rare)
suboptimal encoder decisions rather than signal corruption.

celt_ilog2() could be called with 0 which is undefined.

The overflows reported were:
- Syy in find_best_pitch() in pitch.c
- xy, xx and yy in remove_doubling() in pitch.c

The fixes are:
- Adaptive scaling in pitch_downsample() which also improves quality
- Adding a missing downshift in find_best_pitch()
- More conservative yshift when calling find_best_pitch()

The opus_headers.txt, etc. files are makefile
fragments defining variables with a list of
required header files for the build. As such
they should use the .mk filename extension,
just like opus_sources.mk, etc.

This file is included unconditionally by celt.h.
As such it's a required part of the build and
should be in the header index files.

Ralph Giles authored 13 years ago and Jean-Marc Valin committed 13 years ago

The multiply would overflow with 16 bit ints. Thanks
to Riccardo Micci for pointing out the issue. Thanks
to Tim Terriberry for the valid range of the decay
argument.

Note that ft is unsigned, but always less than 32736,
so we could use a 16 bit signed type here if it allows
the compiler to produce faster code (with signed 16*16
and 16*32 multiplies). In the absense of actual cycle
counts from a real platform, I've left it as an unsigned
for the sake of readability.

For similar reasons we cast (16384-decay) to a signed
integer even though it is also always positive.

Ralph Giles authored 13 years ago and Jean-Marc Valin committed 13 years ago

The parameter descriptions look like they were copied
from encoder_create. Update them for the decode side
and repeat the clarifications about what sample rates
are allowed and what they mean.

Ralph Giles authored 13 years ago and Jean-Marc Valin committed 13 years ago

Also fixes a minor typo.

CLANG IOC no longer likes the 'deterministic random' bitstreams, so move the test_opus_decode bailout up.

Doxygen is smart enough to insert a period if the paragraph
before the @see directive, which starts a new section, doesn't
have one. Unfortunately it's not smart enough to convert a
comma to a period. So while the "description, @see foo" idiom
used for the CTL documentation scans well in the header file,
the Doxygen output end up with "description,.\n".

Minimal change to remove the offending commas.

opus_decode() takes a sixth 'enable_fec' option. Naive invocations
shoudl set this to zero.

We still override the '#if 0' with FIXED_DEBUG, but this
leaves whatever Koen intended here more intact. Suggestion
from Greg Maxwell.

This isn't entirely accurate, since it's also used on integer
math. However, the idea is similar: to add bounds checking.

This code asserts rather than warning, so one must pass
--enable-assertions to configure as well to get any output,
and in that case the first instance is fatal.

Quick testing shows both test_opus_decode and test_opus_encode
trigger the assertions, but running the draft-10 test vectors
does not.

The silk math debug macros include a bounds check on silk_abs.
Because INT_MIN = (-INT_MAX - 1), abs(INT_MIN) can't be
represented as an int. The macro was checking for this value
as 0x8000... without a cast to signed, warning on gcc.

silk/typedef.h already defines minimum values for the int
types, so we correct the warning by using those.

The versions of UADD32 and USUB32 in fixed_debug.h take
unsigned long long (ideally 64 bit) inputs, and range
check the arguments. However, the printed warnings cast
them to (unsigned), which is confusing. Instead, print
the full value passed in.

NB this will make negative values print has huge,
rather than negative, values.