Michael Klingbeil authored 1 year ago and Jean-Marc Valin committed 1 year ago

Signed-off-by: Jean-Marc Valin <jmvalin@amazon.com>

can't link woth libopus since it's already #including C files

Michael Klingbeil authored 1 year ago and Jean-Marc Valin committed 1 year ago

Add unit tests for opus_packet_extensions_count, opus_packet_extensions_parse,
and opus_packet_extensions_generate. Add various assertions for NULL buffers or
negative length arguments. Add explicit check for invalid length in
opus_packet_extensions_count. Check for extension id >127 in
opus_packet_extensions_generate. Check for invalid length input in
opus_packet_extensions_generate.

Signed-off-by: Jean-Marc Valin <jmvalin@amazon.com>

Reviewed by Mark Harris

Marcus Asteborg authored 2 years ago and Mark Harris committed 2 years ago

Signed-off-by: Mark Harris <mark.hsj@gmail.com>

Marcus Asteborg authored 2 years ago and Mark Harris committed 2 years ago

This will fix -Wunused-but-set-variable on gcc
9.3 release build. Also remove unused assert.h.

Signed-off-by: Mark Harris <mark.hsj@gmail.com>

Reviewed by Jean-Marc Valin.

Unlike OPUS_SET_INBAND_FEC(1), the encoder does not necessarily
switch to SILK if we have music.

Make sure we don't try to use the rtcd table when rtcd is disabled.
That code still needs a lot more cleaning up.

Tested on:
 - Linux/x86* with gcc
 - Android armv7 arm64 x86 x86_64 with clang
 - Windows x86 x86_64 with Visual Studio 2017
 - Windows x86 x86_64 with MinGW
 - macOS x86_64 with clang
 - iOS arm64 x86_64 with clang

Co-authored by: Nirbheek Chauhan <nirbheek@centricular.com>

https://gitlab.xiph.org/xiph/opus/-/merge_requests/13

Nirbheek Chauhan authored 4 years ago and Mark Harris committed 4 years ago

_WIN32 is defined on all Windows platforms by every compiler that
targets Windows. We do not need WIN32 at all.

Signed-off-by: Mark Harris <mark.hsj@gmail.com>
Resolves https://github.com/xiph/opus/pull/104

Use the fuzzed sub-length of the input data instead of the whole input.

Marcus Asteborg authored 4 years ago and Jean-Marc Valin committed 4 years ago

Signed-off-by: Jean-Marc Valin <jmvalin@jmvalin.ca>

snprintf is not in C89.  Fixes opus-pedantic test failure introduced
in 59f8e5e4.

Janne Johansson authored 6 years ago and Jean-Marc Valin committed 6 years ago

Signed-off-by: Jean-Marc Valin <jmvalin@jmvalin.ca>

clang -Wcast-align warnings with ambisonics enabled
clang -Wnull-pointer-arithmetic warnings in test_opus_api.c
gcc -Wimplicit-fallthrough warnings on arm
msvc warning C4244 in celt_encoder.c with fixed point

Enables "safes" assertions even with ENABLE_ASSERTIONS isn't set

Andrew Allen authored 7 years ago and Jean-Marc Valin committed 7 years ago

Signed-off-by: Jean-Marc Valin <jmvalin@jmvalin.ca>

Andrew Allen authored 7 years ago and Jean-Marc Valin committed 7 years ago

Modified by Jean-Marc Valin

Signed-off-by: Jean-Marc Valin <jmvalin@jmvalin.ca>

Andrew Allen authored 7 years ago and Jean-Marc Valin committed 7 years ago

OpusProjection* classes
MixingMatrix class
Projection tests

Change-Id: I98644466abf4ffd36e48bdecad1204d69e1539b9
Signed-off-by: Jean-Marc Valin <jmvalin@jmvalin.ca>

|frame_size_enum| in tests/test_opus_encode.cl:117 is flagged as potentially
uninitialized but get_frame_size_enum() will fail anyway if a valid value is
not found.

Allows spaces in path arguments

- celt/modes.c:430:14: warning: cast from 'const unsigned char *' to
  'opus_int16 *' increases required alignment from 1 to 2 [-Wcast-align]
- 'C[0][1]' may be used uninitialized [-Wmaybe-uninitialized]
- Unused variable/parameter
- Value stored is never read
- MSVC warnings about "possible loss of data" due to type conversions
- MSVC warning C4146: unary minus operator applied to unsigned type
- silk/NLSF_del_dec_quant.c:137:20: warning: array subscript is above
  array bounds [-Warray-bounds] (gcc -O3 false positive)
- src/mlp_train.h:39:20: warning: function declaration isn't a prototype
  [-Wstrict-prototypes]
- Remove SMALL_FOOTPRINT code from SSE 4.1 FIR implementation, matching
  the C implementation.

The clang -Wcast-align warnings with SSE intrinsics are a known
clang issue: https://llvm.org/bugs/show_bug.cgi?id=20670

Broken by b0949f11, reported by ko-zu on GitHub.