Silences -fsanitize=unsigned-integer-overflow even though the code was
valid (not undefined) C.

Convert to 16 bits only at the very end

Compensates for the spectral leakage and the fact that we don't have
an explicit masking curve.

Detecting tones can help us prevent the encoder from getting confused
by them.

Was due to nbAvailableBytes not matching the real CBR budget.
Also adding same tell+16<=total_bits condition that the decoder
has for the comb filter just to be on the safe side.
This bug doesn't appear to be possible with the regular Opus API.

Otherwise we would shrink the buffer before initializing it.

Seems to have been in 682b6cf1. There's nothing wrong with either the
encoder or the decoder. Just about how we resynthesize anti-collapse
for mono in the encoder.

Used to be disabled for LM==0 because of the unreliable energy in
one-bin bands. Now we just used the max with the previous energy to
stabilize things.

Reducing dependency chains

If configuring CELT for CBR but controlling the bitrate with
OPUS_SET_BITRATE rather than nbCompressedBytes, then the range
coder buffer would never get resized. AFAICT this could never
be triggered in Opus because CBR was also controlled by
nbCompressedBytes.

CELT encoding would just fail when setting CELT to CBR in hybrid mode.
It was never a problem because hybrid CBR was always used with
OPUS_BITRATE_MAX.

The values were never used, but ubsan + valgrind would complain.

Reviewed by Mark Harris

Hector Martin authored 4 years ago and Mark Harris committed 4 years ago

Signed-off-by: Hector Martin <marcan@marcan.st>
Signed-off-by: Mark Harris <mark.hsj@gmail.com>

As suggested in https://github.com/xiph/opus/pull/83

The error was:
c:\projects\opus\celt\celt_encoder.c(1019): fatal error C1001: An internal error has occurred in the compiler. [C:\projects\opus\win32\VS2015\opus.vcxproj]
  (compiler file 'f:\dd\vctools\compiler\utc\src\p2\main.c', line 255)
   To work around this problem, try simplifying or changing the program near the locations listed above.
  Please choose the Technical Support command on the Visual C++
   Help menu, or open the Technical Support help file for more information

  Internal Compiler Error in C:\Program Files (x86)\Microsoft Visual Studio 14.0\VC\bin\x86_amd64\CL.exe.  You will be prompted to send an error report to Microsoft later.

clang -Wcast-align warnings with ambisonics enabled
clang -Wnull-pointer-arithmetic warnings in test_opus_api.c
gcc -Wimplicit-fallthrough warnings on arm
msvc warning C4244 in celt_encoder.c with fixed point

NaNs should be filtered at the Opus layer, so if there are any in the CELT
encoder, then it's likely something went horribly wrong (e.g. corrupted state).
In that case, better abort than have something bad happen.

This improves cases where a whole region is dominated by a handful of tones

Also adds the error terms for band 0 that were previously omitted

That corresponds to the fundamental for the shortest pitch period allowed

Roman Kalashnikov authored 7 years ago and Ralph Giles committed 7 years ago

Fixes a warning from PVS-Studio. This was a cut-and-paste error
from the stanza above and had no effect.

Signed-off-by: Ralph Giles <giles@thaumas.net>

Linfeng Zhang authored 8 years ago and Jean-Marc Valin committed 7 years ago

Should call celt_inner_prod().

This change is bit exact as original, except for x86 floating-point.
In x86 floating-point, it calls celt_inner_prod_sse() which may have
different output with the change of floating-point operations' orders.

Change-Id: Ia2381e2e198a84296ac28305183f15be842b3454

Signed-off-by: Jean-Marc Valin <jmvalin@jmvalin.ca>