Jesús de Vicente Peña authored 5 years ago and Felicia Lim committed 5 years ago

Fixes to the the activity flag that is passed to Silk so it represents the final activity flag used in the DTX decision

This flag was modified after calling the Silk encoder function. This commit corrects that behavior by introducing those modifications before calling the Silk encoder.

Slightly modified comments by Felicia Lim

Signed-off-by: Felicia Lim <flim@google.com>

Jesús de Vicente Peña authored 5 years ago and Felicia Lim committed 5 years ago

This reverts commit 4f5557c3.

Signed-off-by: Felicia Lim <flim@google.com>

DeadSix27 authored 5 years ago and Jean-Marc Valin committed 5 years ago

The old variable `OPUS_LIBRARY_VERSION`, does not line up with what's used in autoconf, which uses the PACKAGE_VERSION instead, which in turn lines up with what version the projects `opusfile` and `libsndfile` check for, for example.
While at it, I also cleaned up the accidental double up in code.

Signed-off-by: Jean-Marc Valin <jmvalin@jmvalin.ca>

Nathaniel R. Lewis authored 5 years ago and Jean-Marc Valin committed 5 years ago

Signed-off-by: Jean-Marc Valin <jmvalin@jmvalin.ca>

Marcus Asteborg authored 5 years ago and Jean-Marc Valin committed 5 years ago

Signed-off-by: Jean-Marc Valin <jmvalin@jmvalin.ca>

Davide Beatrici authored 5 years ago and Jean-Marc Valin committed 5 years ago

From https://cmake.org/cmake/help/latest/variable/BUILD_SHARED_LIBS.html

:

"Global flag to cause add_library() to create shared libraries if on.

If present and true, this will cause all libraries to be built shared unless the library was explicitly added as a static library. This variable is often added to projects as an option() so that each user of a project can decide if they want to build the project using shared or static libraries."

Signed-off-by: Jean-Marc Valin <jmvalin@jmvalin.ca>

Gustaf Ullberg authored 5 years ago and Felicia Lim committed 5 years ago

Signed-off-by: Felicia Lim <flim@google.com>

The data pointer could be null in the case of DTX or packet loss.

Thanks to Ray Essick

Marcus Asteborg authored 5 years ago and Ralph Giles committed 5 years ago

Signed-off-by: Ralph Giles <giles@thaumas.net>

Thanks to theislander on HA for reporting this.

Adding the OPUS_GET_IN_DTX() query

Marcus Asteborg authored 5 years ago and Jean-Marc Valin committed 5 years ago

If CMAKE_BUILD_TYPE is empty and CFlags are set then only use CFlags.
If None are set then use CMAKE_BUILD_TYPE by Release by default.

Signed-off-by: Jean-Marc Valin <jmvalin@jmvalin.ca>

Marcus Asteborg authored 5 years ago and Jean-Marc Valin committed 5 years ago

Make release build default
Made CUSTOM_MODE an option with default off
Added missing buildflags for Linux and security.

Signed-off-by: Jean-Marc Valin <jmvalin@jmvalin.ca>

Gustaf Ullberg authored 6 years ago and Jean-Marc Valin committed 5 years ago

Signed-off-by: Jean-Marc Valin <jmvalin@jmvalin.ca>

Broken by earlier ARM optimizations.

Marcus Asteborg authored 6 years ago and Jean-Marc Valin committed 5 years ago

Signed-off-by: Jean-Marc Valin <jmvalin@jmvalin.ca>

Reported in https://github.com/xiph/opus/issues/108

snprintf is not in C89.  Fixes opus-pedantic test failure introduced
in 59f8e5e4.

Copy the previous analysis data instead of flagging as invalid

The previous code would go out of sync in those cases.

logE[b] can end up slightly larger than tonal->highE[b] due to rounding

Thanks to Dmitriy for reporting this.

evpobr authored 6 years ago and Jean-Marc Valin committed 6 years ago

Signed-off-by: Jean-Marc Valin <jmvalin@jmvalin.ca>

Sorry, no doc for now

Janne Johansson authored 6 years ago and Jean-Marc Valin committed 6 years ago

Signed-off-by: Jean-Marc Valin <jmvalin@jmvalin.ca>

Addresses the rest of https://github.com/xiph/opus/pull/79

frame diration is only handled at the Opus layer. There's no change
in behaviour, just less puzzling code.

Thanks to Dmitriy <dmilvdv@gmail.com> for reporting this.