We mention this in the description of Channel Mapping Family 0.
Might as well link to RFC 7587.

Review comment from Mo Zanaty.

This improves readability in the xml2rfc html output, but
generates Markdown-style *bold* in the txt output, and
more importantly in the nroff-like html output of the
tools.ietf.org toolchain, which Mo Zanaty and some in
IRC objected to.

Based on Mo Zanaty's review comments.

Response to comments from Mo Zanaty. Using "muxer/demuxer"
really isn't less ambiguous than "encoder/decoder" but does
help distinguish between this draft and a 'codec encoder/decoder'
described by the Opus RFC.

Radu Velea authored 9 years ago and Timothy B. Terriberry committed 9 years ago

Signed-off-by: Timothy B. Terriberry <tterribe@xiph.org>

Radu Velea authored 9 years ago and Timothy B. Terriberry committed 9 years ago

Signed-off-by: Timothy B. Terriberry <tterribe@xiph.org>

Jonathan Lennox authored 9 years ago and Timothy B. Terriberry committed 9 years ago

Fixes build failure on platforms with MAY_HAVE_SSE4_1 (but not PRESUME_SSE4_1) with --enable-intrinsics.

Mark Harris authored 9 years ago and Jean-Marc Valin committed 9 years ago

Signed-off-by: Jean-Marc Valin <jmvalin@jmvalin.ca>

Mark Harris authored 9 years ago and Jean-Marc Valin committed 9 years ago

Signed-off-by: Jean-Marc Valin <jmvalin@jmvalin.ca>

These were causing "syntax error near unexpected token `fi'" in the
 generated configure on some systems, because they produced an

  else

  fi

 with no commands between the two.

Rhishikesh Agashe authored 9 years ago and Jean-Marc Valin committed 9 years ago

Signed-off-by: Jean-Marc Valin <jmvalin@jmvalin.ca>

Timothy B. Terriberry authored 9 years ago and Jean-Marc Valin committed 9 years ago

Some of the fields present in NE10's float state struct are not
 present in the fixed-point version, but we were generating
 initializers for them anyway.
Also, the float modes were not up-to-date with the output of
 dump_modes.

Viswanath Puttagunta authored 9 years ago and Jean-Marc Valin committed 9 years ago

Extends usage of NEON optimized fixed-point FFT optimizations
in libNE10 to clt_mdct_forward and clt_mdct_backward.

Signed-off-by: Timothy B. Terriberry <tterribe@xiph.org>

Viswanath Puttagunta authored 9 years ago and Jean-Marc Valin committed 9 years ago

Uses NEON optimized fixed point FFT routines in NE10 library.

Signed-off-by: Timothy B. Terriberry <tterribe@xiph.org>

Viswanath Puttagunta authored 9 years ago and Jean-Marc Valin committed 9 years ago

Signed-off-by: Viswanath Puttagunta <viswanath.puttagunta@linaro.org>
Signed-off-by: Timothy B. Terriberry <tterribe@xiph.org>

Viswanath Puttagunta authored 9 years ago and Jean-Marc Valin committed 9 years ago

Optimize opus decode (float only) use case using ARM NE10.
Mainly effects opus_ifft and ctl_mdct_backward and related
functions.

Work based on previous Encode optimization using ARM NE10
library. See previous commit for details on how to enable
this.

Signed-off-by: Timothy B. Terriberry <tterribe@xiph.org>

Viswanath Puttagunta authored 9 years ago and Jean-Marc Valin committed 9 years ago

Optimize opus encode (float only) usecase using ARM NE10
library. Mainly effects opus_fft and ctl_mdct_forward
and related functions.

This optimization can be used for ARM CPUs that have NEON
VFP unit. This patch only enables optimizations for ARMv7.

Official ARM NE10 library page available at
http://projectne10.github.io/Ne10/



To enable this optimization, use
--enable-intrinsics --with-NE10=<install_prefix>
or
--enable-intrinsics --with-NE10-libraries=<NE10_lib_dir> --with-NE10-includes=<NE10_includes_dir>

Compile time checks made during configure process to make sure
optimization option available only when compiler supports NEON
instrinsics.

Runtime checks made to make sure optimized functions only called
on appropriate hardware.

Signed-off-by: Timothy B. Terriberry <tterribe@xiph.org>

Timothy B. Terriberry authored 9 years ago and Jean-Marc Valin committed 9 years ago

This library is linked statically with libopus.so, so nothing
 changes on an installed system.
This merely simplifies linking in the unit tests.
Based in part on a patch originally by Viswanath Puttagunta
 <viswanath.puttagunta@linaro.org>.

Timothy B. Terriberry authored 9 years ago and Jean-Marc Valin committed 9 years ago

This is needed for the SMALL_DIV_TABLE constants added in commit
 ec5d01cb.

Rhishikesh Agashe authored 9 years ago and Jean-Marc Valin committed 9 years ago

Brings MIPS in sync with the ARM/SSE optimizations that added "arch" parameters.

Signed-off-by: Jean-Marc Valin <jmvalin@jmvalin.ca>

Mark Harris authored 9 years ago and Jean-Marc Valin committed 9 years ago

Signed-off-by: Jean-Marc Valin <jmvalin@jmvalin.ca>

Mark Harris authored 9 years ago and Jean-Marc Valin committed 9 years ago

Fix out-of-bounds memory read in multichannel surround analysis
with float input that contains NaNs.  Found by afl-fuzz.

Signed-off-by: Jean-Marc Valin <jmvalin@jmvalin.ca>

autoreconf looks for ACLOCAL_*FLAGS in Makefile.am and will
pass that on when it invokes aclocal. Furthermore, setting
a local like this doesn't make it available to subcommands,
so the line has no effect.

Jonathan Lennox authored 9 years ago and Jean-Marc Valin committed 9 years ago

This patch lets you pass paths for opus_demo and opus_compare to the
run_vectors.sh script.

The motivation for this was for my aarch64 patches (forthcoming),
which I've been testing under qemu.  I want to run an emulated
opus_demo, but a native opus_compare, so the script completes in a
reasonable amount of time.

Jonathan Lennox authored 9 years ago and Jean-Marc Valin committed 9 years ago

This patch adds a macro abstracting the condition under which the silk
math macros use opus_int64-based calculations rather than opus_int32.
No substantive change, but will make it easier to adjust if additional
such platforms are found in the future.

Jonathan Lennox authored 9 years ago and Jean-Marc Valin committed 9 years ago

Use ProjectReference rather than AdditionalDependencies for test programs, so build dependencies are right.

Actually add source code to opus_demo project, and fix its include paths.

Jonathan Lennox authored 9 years ago and Jean-Marc Valin committed 9 years ago

Enable x86 intrinsics when building in floating-point mode.
Support SSE as an arch value.
Use RTCD to conditionally enable existing floating-point Celt SSE code.
Call functions directly (without RTCD) when their architecture can be presumed.
Use SSE4.1 intrinsics optimized code for Silk even in floating-point mode.

Jonathan Lennox authored 9 years ago and Jean-Marc Valin committed 9 years ago

Move SSE2 and SSE4.1 intrinsics functions to separate files, to be compiled with appropriate compiler flags. Otherwise, compilers are allowed to take advantage of (e.g.) -msse4.1 to generate code that uses SSE4.1 instructions, even when no SSE4.1 intrinsics are explicitly used in the source.

Jonathan Lennox authored 9 years ago and Jean-Marc Valin committed 9 years ago

In optimized mode, don't force Clang to use explicit load/store for _mm_cvtepi16_epi32, only for _mm_cvtepi8_epi32. Adjust comment accordingly.

Jonathan Lennox authored 9 years ago and Jean-Marc Valin committed 9 years ago

Actually try to compile intrinsics rather than using the output of --help.
Allow caller of configure script to set custom compiler options to enable intrinsics.
Detect when intrinsics are always available, without needing special compiler options.
Make naming of #defines for detected intrinsics support more systematic.

Koen Vos authored 9 years ago and Jean-Marc Valin committed 9 years ago

Signed-off-by: Jean-Marc Valin <jmvalin@jmvalin.ca>

Koen Vos authored 9 years ago and Jean-Marc Valin committed 9 years ago

The bug was caused by an improper feedback of the per-frame bitrate, causing
the bitrate to jump up and down from frame to frame, within a packet.
The patch avoids this, and also gives a slight improvement in general for
multi-frame packets, even without FEC.

Signed-off-by: Jean-Marc Valin <jmvalin@jmvalin.ca>