Petter Reinholdtsen authored 2 weeks ago and Tristan Matthews committed 2 weeks ago

These were forgotten when arm support were imporoved.

Fixes #2338

Export the .tar.xz and .zip source packages as well as the
base tar.gz version. Some downstream projects (VLC) expect
the tar.xz version and this makes it easier to reference.

Also log the checksums of the source packages generated
by `make distcheck` for later comparison.

Increased libtool TH*_LIB_CURRENT and thus minor version of SONAME as
implementation of the library changed.

Adjusted THDEC_LIB_REVISION which was forgotten in the 1.2.0beta1
release.

Fixes #2319.
Fixes #17 on github.

This is already being done for GCC et al.

Felix Paul Kühne authored 3 weeks ago and Tristan Matthews committed 3 weeks ago

"This solves compilation issues from the future." - the original commit message, however
since that was 10 years ago the "future" has most likely passed.

Signed-off-by: Tristan Matthews <tmatth@videolan.org>

Signed-off-by: Petter Reinholdtsen <pere@hungry.com>

Signed-off-by: Petter Reinholdtsen <pere@hungry.com>

Updated the most used links and a few more after manually checking the
https variant of the link still lead to a web page.  Some URLs no longer
work, these were not changed to https. Also changed xiph.org->www.xiph.org.

Did not change anything in the draft RFCs.

Fixes #2332

Patch from fabio, wrapped to fit within 80 char lines, and added
exit code 1 to error situations.

Fixes #2336

Leftover from 10b3ce94.

Fixes #2335

This allow us to see how the MacOSX build is working.

This better reflect the set of tools involved.

This avoid calling malloc(0) expecting a non-NULL pointer returned,
and make the code in oc_comment_unpack() not depend on non POSIX specified
behaviour.

Ensured comment_lengths and user_comments are NULL if there are no comments.

Thanks to Eric Lasota for noticing.

Fixes #2304

Document the need for ogg 1.3.4 and use the 1.2.0 version number
more places.  Move required ogg version to configure.ac substitution
variable.

Fixes #2328

Based on script posted to https://bugs.debian.org/516343 in 2009
by Robert Millan.

Fixes #1601

Fixes #2331

Increased libtool TH*_LIB_CURRENT and thus minor version of SONAME as
API of a few methods changes by adding 'const' to some of the char *
arguments in codec.h.

A 1.2.0 release is planned in two weeks.

Related to #2319.

CI currently does not thoroughly test encoding and decoding (except for
encoding zeroed dummy frames).
Testing --disable-asm is still useful because it ensures that the code compiles
on platforms where there are no ASM optimizations and the generic C code paths
are used.

Adjust clang CI run to report warning about reserved identifiers.

A crash was discovered using input fuzzying, in th_decode_ceaderin()
where the len value in the oc_fuff_tree_unpack() can end up as -1.
Added a check to ensure this do not happen.

Based on feedback from Timothy B. Terriberry.

The issue was discovered using gcc sanitazion, which reported the following:

huffdec.c:228:27: runtime error: shift exponent -1 is negative
    #0 0x5d471012bfd0 in oc_huff_tree_unpack /home/uos/libtheora-18570/theora/lib/huffdec.c:228
    #1 0x5d471012c134 in oc_huff_trees_unpack /home/uos/libtheora-18570/theora/lib/huffdec.c:392
    #2 0x5d471010a98c in oc_setup_unpack /home/uos/libtheora-18570/theora/lib/decinfo.c:169
    #3 0x5d471010a98c in oc_dec_headerin /home/uos/libtheora-18570/theora/lib/decinfo.c:238
    #4 0x5d471010a98c in th_decode_headerin /home/uos/libtheora-18570/theora/lib/decinfo.c:266
    #5 0x5d47100fd638 in TheoraDecoder::initialize() /home/uos/libtheora-18570/libtheora-18570/fuzzer.cpp:66
    #6 0x5d47100ffa76 in TheoraDecoder::Run() /home/uos/libtheora-18570/libtheora-18570/fuzzer.cpp:180
    #7 0x5d47100ffe48 in main /home/uos/libtheora-18570/libtheora-18570/fuzzer.cpp:240
    #8 0x7cc9a5e29d8f in __libc_start_call_main ../sysdeps/nptl/libc_start_call_main.h:58
    #9 0x7cc9a5e29e3f in __libc_start_main_impl ../csu/libc-start.c:392
    #10 0x5d47100f9964 in _start (/home/uos/libtheora-18570/libtheora-18570/poc1+0x83964)

Fixes github pull request #19.

Do not build examples, as it require libvorbis, and do not build
documentation as it require a host of programs not available
during cross building.

During video playout using player_example with gcc sanitaztions
enabled, new bit shifting of negative values were discovered.
Replaced this with multiplication too.

Leftover changes from a6766c94.

Use multiplication instead, allowing the compiler to optimize to
bitshifts if it believe it to be safe.

Partly solves github issue #18.

These have not been updated since before the code was migrated to
git, and both no longer make sense and are not correct.

The 'int x=x' style statement do not make sense and cause problems with
some compilers.  Replace it with more sensible initializers to ensure
the value have a well known starting point.  Using initializers
proposed by Timothy B. Terriberry in !25.

Added -Werror=uninitialized -Winit-self to default GCC build to ensure
this style of statement do not sneak into the code again.

Fixes #2317

The security issue CVE-2024-56431 was discovered using GCC address
sanitaztion.  Make it easier to run this check, and run it in
gitlab CI.

Based on a comment in !28.

Ran 'cp Doxygen.in Doxygen; doxygen -u; cp Doxygen Doxygen.in' and
removed DOT_FONTNAME reference to non-free font.

Check if argument is null before using this approach, and just return
zero when the value to do bit count on is zero.

Fixes a issue discovered by --enable-gcc-sanitizers in !31:

  ../../lib/encode.c:1384:49: runtime error: passing zero to clz(),
    which is not a valid argument
    #0 0x7f0af5dae97d in th_encode_ctl ../../lib/encode.c:1384
    #1 0x7f0af5e2eb97 in theora_encode_init ../../lib/encapiwrapper.c:72
    #2 0x55fd4beb18b7 in granulepos_test_encode
     ../../tests/granulepos_theora.c:71
    #3 0x55fd4beb126d in main ../../tests/granulepos_theora.c:137
    #4 0x7f0af51d3249 in __libc_start_call_main
     ../sysdeps/nptl/libc_start_call_main.h:58
    #5 0x7f0af51d3304 in __libc_start_main_impl ../csu/libc-start.c:360
    #6 0x55fd4beb1300 in _start
     (/home/user/libtheora/build/tests/.libs/granulepos_theoraenc+0x2300)

Fixes #2323

The last iteration of the loop execute 1<<63, which would push the
result into the signed bit of a signed 64 bit type, and this
move into currently undefined behaviour with C99.  Avoid the
issue by making the operation work on unsigned 64 bit type instead.

This require libogg version to 1.3.4, raise autotools dependency check
to look for this.

Partly solves github issue #18.

Use multiplication instead, allowing the compiler to optimize to
bitshifts if it believe it to be safe.

Fixes a few issues discovered by --enable-gcc-sanitize-address in !31.

Use multiplication instead, allowing the compiler to optimize to
bitshifts if it believe it to be safe.

Partly solves github issue #18.