This fixes a problem where we could end up starving the redundancy
frame, especially for CBR. The solution is to make sure that some
bits are left available -- assuming we use the same rate for redundancy
as for the rest of the frame.

Doing it this way means it's only the weird corner case that actually
pays for being weird, and we don't litter the build dir with an extra
link that normal builds really don't need at all.

It also avoids the problem of platforms where LN_S isn't well defined.

This could be confusing/misleading.

Mostly this is for people building other things using an uninstalled
opus tree so that the opus-uninstalled.pc will return a working -I
with --cflags when PKG_CONFIG_PATH is set to point to the build dir.

The version of AC_OUTPUT that takes parameters has long been
deprecated now, and replaced by AC_CONFIG_* macros, so pass them
with AC_CONFIG_FILES, since we're now using AC_CONFIG_COMMANDS
to do the above.

The floating-point build calls a number of math library
functions, and linking with libm is technically necessary.
It wasn't obvious because most systems support shlib
dependencies and pulled it in that way, or supply the
referenced functions with intrinsics. Discovered the issue
trying to build libopusfile against the uninstalled static
libopus, which unlike opus-tools, doesn't itself need libm.

The -lm argument is only added to Libs for the floating-
point (default) build. It's not necessary for the fixed-
point build.

Also mark which build was used in the .pc file description.

This isn't used anywhere in the code, floating point is just the
default unless FIXED_POINT is defined.

In the speex codebase, arch.h has a check that both FIXED_POINT
and FLOATING_POINT aren't defined simultaneously, in part as a
check that the build system was constructed with thought about
these and other defines. However, we don't have such a check
and to me it seems unnecessary code.

While a feature of Opus, its applications are not limited
to contexts where low delay is important.

Diego Elio Pettenò authored 12 years ago and Jean-Marc Valin committed 12 years ago

These are only being used outside if the translation unit and only in
a few codepaths; by making them static in the header, the compiler can
optimize them quickly.

This avoids GOT-based access to the external symbol on Unix, and can
allow for constant propagation to optimize the code.

Signed-off-by: Diego Elio Pettenò <flameeyes@flameeyes.eu>

Diego Elio Pettenò authored 12 years ago and Jean-Marc Valin committed 12 years ago

Signed-off-by: Diego Elio Pettenò <flameeyes@flameeyes.eu>

Diego Elio Pettenò authored 12 years ago and Jean-Marc Valin committed 12 years ago

This is similar to the change for functions, but is only used to
perform DCE.

Signed-off-by: Diego Elio Pettenò <flameeyes@flameeyes.eu>

Diego Elio Pettenò authored 12 years ago and Jean-Marc Valin committed 12 years ago

This allows the compiler to perform more optimization on them as it
knows how the functions are being called.

Signed-off-by: Diego Elio Pettenò <flameeyes@flameeyes.eu>

Diego Elio Pettenò authored 12 years ago and Jean-Marc Valin committed 12 years ago

While this is not making a huge difference it still makes the code
more consistent.

Signed-off-by: Diego Elio Pettenò <flameeyes@flameeyes.eu>

Timothy B. Terriberry authored 12 years ago and Jean-Marc Valin committed 12 years ago

This patch also includes some small edits/additions to the main API
 documentation.

Timothy B. Terriberry authored 12 years ago and Jean-Marc Valin committed 12 years ago

This patch also includes some small edits for the main API
 documentation.

Timothy B. Terriberry authored 12 years ago and Jean-Marc Valin committed 12 years ago

This allows the decoder to be compiled with
 NONTHREADSAFE_PSEUDOSTACK to move the memory for large buffers off
 the stack for devices where it is very limited.
This patch only attempts to do this for the decoder.
The encoder still requires more than 10 kB of stack.

Timothy B. Terriberry authored 12 years ago and Jean-Marc Valin committed 12 years ago

This avoids allocating any buffers on the stack that depend on the
 total channel count.
Such buffers could easily exceed the size of the
 NONTHREADSAFE_PSEUDOSTACK.
It also checks the frame_size argument in both the encoder and
 decoder to avoid allocating large stack buffers for opus_encode()
 calls that would fail anyway or opus_decode() calls that would
 never use all that space anyway.

This makes simple syntax highlighters (e.g., vim) stop complaining
 because they don't parse the #ifdef's.

Instead use cd inside the makefiles.
This fixes 'make check', etc. with some non-gnu makes. (HPUX, for example)

 On some systems (HPPA+HPUX+GCC) -fstatck-protector was causing failures not
at build or link time but at actual runtime. This is much less reasonable to
detect from autotools. It looks this this really can only safely be a white-
list, and the systems which would be whitelisted often already pick up the
setting from the OS build environment in any case.  It isn't important for
OPUS, we were just using it as belt-and-suspenders security and because it
makes some failure types easier to troubleshoot.

Thanks to Andrew D'Addesio for the report.

Further cleanup of the confusion with the version string settings.

I'm not sure how this worked before, the the previous version
string fiddling commit ended up not defining OPUS_VERSION in
the autoconf build, so opus_get_version_string() returned
'unknown'.