Marcin Gorzel authored 6 years ago and Felicia Lim committed 6 years ago

Fixes issue #95 on GitHub.

Signed-off-by: Felicia Lim <flim@google.com>

The error was:
c:\projects\opus\celt\celt_encoder.c(1019): fatal error C1001: An internal error has occurred in the compiler. [C:\projects\opus\win32\VS2015\opus.vcxproj]
  (compiler file 'f:\dd\vctools\compiler\utc\src\p2\main.c', line 255)
   To work around this problem, try simplifying or changing the program near the locations listed above.
  Please choose the Technical Support command on the Visual C++
   Help menu, or open the Technical Support help file for more information

  Internal Compiler Error in C:\Program Files (x86)\Microsoft Visual Studio 14.0\VC\bin\x86_amd64\CL.exe.  You will be prompted to send an error report to Microsoft later.

Felicia Lim authored 6 years ago and Jean-Marc Valin committed 6 years ago

Signed-off-by: Jean-Marc Valin <jmvalin@jmvalin.ca>

Emily Bowman authored 6 years ago and Mark Harris committed 6 years ago

[mark.hsj: Add other missing files and update filter file]
Signed-off-by: Mark Harris <mark.hsj@gmail.com>
Fixes https://github.com/xiph/libopusenc/issues/9
Fixes https://github.com/xiph/opus-tools/issues/32

Didn't cause any problem, but still good to fix. Reported by
keithchugg on github.

clang -Wcast-align warnings with ambisonics enabled
clang -Wnull-pointer-arithmetic warnings in test_opus_api.c
gcc -Wimplicit-fallthrough warnings on arm
msvc warning C4244 in celt_encoder.c with fixed point

Causes a warning with -Wnull-pointer-arithmetic and the code wasn't doing
anything anyway (the ctl call ignores NULLs)

This gets rid of false positives in static analysis
(see https://trac.webkit.org/changeset/232236/webkit)

Fixes test_opus_projection failure under ubsan, due to clz(0).

Don't assume that frames larger than 20 ms save any overhead compared to 20 ms.

The bug was triggered because f982b84d started using prefill for
SILK bandwidth changes, which reinitialized the encoder state and
prevented the variable lowpass from working properly. To fix the problem,
we preserve the sampling rate and variable low-pass when prefilling.

Using a finer table for the rate to SNR curves in silk_control_SNR().
It's now possible to have an SNR that reaches 0, so we can lower bitrate
down to ~5 kbps for narrowband and 5.5 kbps for wideband.

NaNs should be filtered at the Opus layer, so if there are any in the CELT
encoder, then it's likely something went horribly wrong (e.g. corrupted state).
In that case, better abort than have something bad happen.

Gustaf Ullberg authored 6 years ago and Jean-Marc Valin committed 6 years ago

Signed-off-by: Jean-Marc Valin <jmvalin@jmvalin.ca>

It is the size array that must be non-null.

Only converted the ones that are really sure (not signal-dependent)
and that shouldn't add much run-time complexity