Coverity warns about the possibly-overlappying memcpy in this
block, presumedly because it can't prove predictLPCOrder <= MAX_LPC_ORDER
here. Add an assert to make the intent clear in code as well
as in the comment.

We were previously returning OPUS_BAD_ARG because the failure was
only detected in opus_repacketizer_out_range_impl() rather than in
opus_repacketizer_cat(). Checking the return value from opus_repacketizer_cat()
also addresses the last outstanding Coverity defect.

Michael Graczyk authored 8 years ago and Jean-Marc Valin committed 8 years ago

Signed-off-by: Jean-Marc Valin <jmvalin@jmvalin.ca>

Michael Graczyk authored 8 years ago and Jean-Marc Valin committed 8 years ago

Signed-off-by: Jean-Marc Valin <jmvalin@jmvalin.ca>

Michael Graczyk authored 8 years ago and Jean-Marc Valin committed 8 years ago

The implementation currently only codes each channel independently with no
special allocation rules.

Signed-off-by: Jean-Marc Valin <jmvalin@jmvalin.ca>

That's the only size that's not a multiple of 4, so we just discard 2 samples
from the calculation.

Reported by Durandal.

Reported by Durandal.

We just explicitly allow the overflow with silk_MLA_ovflw() since the result
seems to be correct because the overflows cancel each other.

This could lead to an integer overflow. Also, refactored the code a bit

Felicia Lim authored 8 years ago and Jean-Marc Valin committed 8 years ago

Slightly modified by Jean-Marc Valin

Signed-off-by: Jean-Marc Valin <jmvalin@jmvalin.ca>

Jonathan Lennox authored 8 years ago and Jean-Marc Valin committed 8 years ago

Signed-off-by: Jean-Marc Valin <jmvalin@jmvalin.ca>

Jonathan Lennox authored 8 years ago and Jean-Marc Valin committed 8 years ago

Signed-off-by: Jean-Marc Valin <jmvalin@jmvalin.ca>

*-gnu.S are generated by arm2gnu.pl (derf)
celt/arm/armopts.s is also generated from armopts.s.in

Generated by newer versions of Doxygen when built with sqlite3.

Thanks to derf for the report.

Visual Studio 2015 has been out for a while, and has a gratis
version. It doesn't make sense to maintain parallel support
for older releases.

Needed after 6e961737.

This was adding in the MSVC project updates, but isn't correct.

fix build settings for DLL project, runtime library must be linked to DLL too to prevent heap deallocation error

Added Visual Studio 2015 solution and added ReleaseDLL and DebugDLL Project settings to produce .dll file instead of .lib

The effect was to always set HB_gain to 1.

If building a static library, marking symbols as dllexport causes them
to be exported from the final executable. For example, run
objdump -x opus_demo.exe on a --disabled-shared build and look for the
export table; there should not be one in a normal Win32 .exe file, but
when linking static libopus, the exe exports all of the opus_* public
functions.

Use the libtool-defined DLL_EXPORT flag to determine whether we are
building a DLL and only specify __declspec(dllexport) in that case.