Jesús de Vicente Peña authored 4 years ago and Felicia Lim committed 4 years ago

Signed-off-by: Felicia Lim <flim@google.com>

Tested on:
 - Linux/x86* with gcc
 - Android armv7 arm64 x86 x86_64 with clang
 - Windows x86 x86_64 with Visual Studio 2017
 - Windows x86 x86_64 with MinGW
 - macOS x86_64 with clang
 - iOS arm64 x86_64 with clang

Co-authored by: Nirbheek Chauhan <nirbheek@centricular.com>

https://gitlab.xiph.org/xiph/opus/-/merge_requests/13

Nirbheek Chauhan authored 4 years ago and Mark Harris committed 4 years ago

Actually check for read errors instead of just storing the
return value in a variable that then never gets checked.

Also fixes "conversion from 'size_t' to 'int', possible loss
of data" compiler warnings on Windows with MSVC caused by
storing the size_t returned by fread() into an int variable.

Signed-off-by: Mark Harris <mark.hsj@gmail.com>

Marcus Asteborg authored 4 years ago and Jean-Marc Valin committed 4 years ago

Build time improvement, for MSVC use intrin0.h instead of intrin.h and remove usage of stdio.h in production code

Signed-off-by: Jean-Marc Valin <jmvalin@jmvalin.ca>

Jesús de Vicente Peña authored 5 years ago and Felicia Lim committed 5 years ago

Signed-off-by: Felicia Lim <flim@google.com>

Jesús de Vicente Peña authored 5 years ago and Felicia Lim committed 5 years ago

Reland "Fixes to the the activity flag that is passed to Silk so it represents the final activity flag used in the DTX decision"

This flag was modified after calling the Silk encoder function. This commit corrects that behavior by introducing those modifications before calling the Silk encoder.

Slightly modified comments by Felicia Lim

Signed-off-by: Felicia Lim <flim@google.com>

Revert "Fixes to the the activity flag that is passed to Silk so it represents the final activity flag used in the DTX decision"

This reverts commit ea3b30f9.

Jesús de Vicente Peña authored 5 years ago and Felicia Lim committed 5 years ago

Fixes to the the activity flag that is passed to Silk so it represents the final activity flag used in the DTX decision

This flag was modified after calling the Silk encoder function. This commit corrects that behavior by introducing those modifications before calling the Silk encoder.

Slightly modified comments by Felicia Lim

Signed-off-by: Felicia Lim <flim@google.com>

Gustaf Ullberg authored 5 years ago and Felicia Lim committed 5 years ago

Signed-off-by: Felicia Lim <flim@google.com>

The data pointer could be null in the case of DTX or packet loss.

Gustaf Ullberg authored 6 years ago and Jean-Marc Valin committed 5 years ago

Signed-off-by: Jean-Marc Valin <jmvalin@jmvalin.ca>

Copy the previous analysis data instead of flagging as invalid

The previous code would go out of sync in those cases.

logE[b] can end up slightly larger than tonal->highE[b] due to rounding

Thanks to Dmitriy for reporting this.

frame diration is only handled at the Opus layer. There's no change
in behaviour, just less puzzling code.

Thanks to Dmitriy <dmilvdv@gmail.com> for reporting this.

Without that change, a very long (> 682 ms) illegal packet could trigger
a wrap-around in the test and be accepted as valid.

Only 16-bit architectures (e.g. TI C5x) were affected.

Marcin Gorzel authored 6 years ago and Felicia Lim committed 6 years ago

Fixes issue #95 on GitHub.

Signed-off-by: Felicia Lim <flim@google.com>

Felicia Lim authored 6 years ago and Jean-Marc Valin committed 6 years ago

Signed-off-by: Jean-Marc Valin <jmvalin@jmvalin.ca>

clang -Wcast-align warnings with ambisonics enabled
clang -Wnull-pointer-arithmetic warnings in test_opus_api.c
gcc -Wimplicit-fallthrough warnings on arm
msvc warning C4244 in celt_encoder.c with fixed point

Causes a warning with -Wnull-pointer-arithmetic and the code wasn't doing
anything anyway (the ctl call ignores NULLs)

This gets rid of false positives in static analysis
(see https://trac.webkit.org/changeset/232236/webkit)

Fixes test_opus_projection failure under ubsan, due to clz(0).

Don't assume that frames larger than 20 ms save any overhead compared to 20 ms.