The previous code would go out of sync in those cases.

logE[b] can end up slightly larger than tonal->highE[b] due to rounding

Thanks to Dmitriy for reporting this.

frame diration is only handled at the Opus layer. There's no change
in behaviour, just less puzzling code.

Thanks to Dmitriy <dmilvdv@gmail.com> for reporting this.

Without that change, a very long (> 682 ms) illegal packet could trigger
a wrap-around in the test and be accepted as valid.

Only 16-bit architectures (e.g. TI C5x) were affected.

Marcin Gorzel authored 6 years ago and Felicia Lim committed 6 years ago

Fixes issue #95 on GitHub.

Signed-off-by: Felicia Lim <flim@google.com>

Felicia Lim authored 6 years ago and Jean-Marc Valin committed 6 years ago

Signed-off-by: Jean-Marc Valin <jmvalin@jmvalin.ca>

clang -Wcast-align warnings with ambisonics enabled
clang -Wnull-pointer-arithmetic warnings in test_opus_api.c
gcc -Wimplicit-fallthrough warnings on arm
msvc warning C4244 in celt_encoder.c with fixed point

Causes a warning with -Wnull-pointer-arithmetic and the code wasn't doing
anything anyway (the ctl call ignores NULLs)

This gets rid of false positives in static analysis
(see https://trac.webkit.org/changeset/232236/webkit)

Fixes test_opus_projection failure under ubsan, due to clz(0).

Don't assume that frames larger than 20 ms save any overhead compared to 20 ms.

The bug was triggered because f982b84d started using prefill for
SILK bandwidth changes, which reinitialized the encoder state and
prevented the variable lowpass from working properly. To fix the problem,
we preserve the sampling rate and variable low-pass when prefilling.

Gustaf Ullberg authored 6 years ago and Jean-Marc Valin committed 6 years ago

Signed-off-by: Jean-Marc Valin <jmvalin@jmvalin.ca>

We make sure the CELT PLC we do in the transition uses the same bandwidth
as the previous (CELT) packet and not the new bandwidth

Andrew Allen authored 7 years ago and Jean-Marc Valin committed 7 years ago

Signed-off-by: Jean-Marc Valin <jmvalin@jmvalin.ca>

A second-order DC rejection filter is uselsss unless we have complex
poles. However, complex poles means we have to compute the filter as a
single pass (rather than two casdaded first-order filters), which has
numerical issues that would require a higher complexity to solve.
So rather than waste cycles with a second-order filter (with a longer
impulse response), we just go with a first-order filter.

Fixes a "regression" from 1.2 to 1.3-beta that was especially noticeable
on a Korean speech sample. (it wasn't a real regression since 1.2 only
worked because it was using CELT)

That corresponds to the fundamental for the shortest pitch period allowed

Andrew Allen authored 7 years ago and Jean-Marc Valin committed 7 years ago

Change-Id: I3db285875b6b5548decc436be00096b97be1be3c
Signed-off-by: Jean-Marc Valin <jmvalin@jmvalin.ca>

Andrew Allen authored 7 years ago and Jean-Marc Valin committed 7 years ago

Signed-off-by: Jean-Marc Valin <jmvalin@jmvalin.ca>