This was reported by Juri Aedla and is limited to reading memory up
to about 60 kB beyond the compressed buffer. This can only be triggered
by a compressed packet more than about 16 MB long, so it's not a problem
for RTP. In theory, it *could* crash an Ogg decoder if the memory just after
the incoming packet is out-of-range.

The README doesn't say anything about this particular define.
Refer people to config.h and the other build files for examples.

These files has unix line endings, while the other
project files have dos line endings.

I hoped this would fix the link error about corrupt
or invalid files with these projects, but it doesn't.
Running 'Update project files...' in the VS2012 IDE
is a work around, but it just adds a <PlatformToolset>
element to each <PropertyGroup> and a line ending at
the end of the file.

Commits ae0e2ca8 and 6906210c split encode and decode
support into separate files to help reduce the footprint
of decode-only builds.

This commit adds the new source files to the MSVC
project files, fixing that build.

Delays stack allocations as much as possible, and makes some of these
allocations conditional.

As reported by Mark Warner opus_multistream_*_create were depending on
 the behavior of malloc(0) in order to correctly report some kinds of
 argument errors. Bad arguments could be incorrectly reported as
 allocation failures. This changes multistream to explicitly check the
 arguments like the single stream _create functions. The unit tests were
 enough to catch this on systems where malloc(0) returns NULL but didn't
 catch it on other systems because the later _init call would catch the
 bad arguments and trigger the correct error if and only if the malloc
 didn't return a null pointer.

In multistream_encoder_init failures of the internal non-multistream
 init calls were not being caught and propagated. Decode didn't have
 this problem. This propagates the errors and adds additional tests
 (the multistream encoder api is sill under tested) that would have
 detected this error.

Plus add some stronger tests for things like error==NULL for the _create
 functions that take a pointer for error output.

Specify the correct debug runtime libraries for the test
and demo executables to prevent mismatch warnings with
the default runtime.

Signed-off-by: Ralph Giles <giles@mozilla.com>

Updates the project files to include the new encoder source files.
Use OPUS_RESTRICT and include config.h to set the proper defines
for build under MSVC.

The Microsoft compiler warns about precision reduction from
default double literals to the floats we generally use outside
the fixed-point build. Avoid these by qualifying the literals
as floats.

Thanks to derf for review.

Adds a gain cross-fade to avoid discontinuities and moves it
to a place where it won't affect SILK

Conflicts:

	src/opus_encoder.c

Koen Vos authored 12 years ago and Jean-Marc Valin committed 12 years ago

Conflicts:

	src/opus_multistream.c
	src/opus_private.h

Also removes the -exp_analysis suffix from opus_get_version_string()
and fixes a "ISO C90 forbids mixed declarations and code" warning.

This fixes a problem where we could end up starving the redundancy
frame, especially for CBR. The solution is to make sure that some
bits are left available -- assuming we use the same rate for redundancy
as for the rest of the frame.

Prefilling didn't use the right offset because of the extra_delay
changes introduced in the analysis branch.

Diego Elio Pettenò authored 12 years ago and Jean-Marc Valin committed 12 years ago

This allows the compiler to perform more optimization on them as it
knows how the functions are being called.

Signed-off-by: Diego Elio Pettenò <flameeyes@flameeyes.eu>

Diego Elio Pettenò authored 12 years ago and Jean-Marc Valin committed 12 years ago

While this is not making a huge difference it still makes the code
more consistent.

Signed-off-by: Diego Elio Pettenò <flameeyes@flameeyes.eu>

Timothy B. Terriberry authored 12 years ago and Jean-Marc Valin committed 12 years ago

This avoids allocating any buffers on the stack that depend on the
 total channel count.
Such buffers could easily exceed the size of the
 NONTHREADSAFE_PSEUDOSTACK.
It also checks the frame_size argument in both the encoder and
 decoder to avoid allocating large stack buffers for opus_encode()
 calls that would fail anyway or opus_decode() calls that would
 never use all that space anyway.

This makes simple syntax highlighters (e.g., vim) stop complaining
 because they don't parse the #ifdef's.

Microsoft Visual Studio 2010 warns about 'C4146: unary minus
operator applied to unsigned type, result still unsigned'
because of the '&-sizeof(void*)' in align().

This commit works around the warning by casting the size_t
to int before negation.

Patch by Hauke, who reported the issue on the opus mailing
list. Reviewed by derf.

Jean-Marc Valin authored 12 years ago and Gregory Maxwell committed 12 years ago

This implements an API used in future encoders to avoid dynalloc doing silly things
on periodic LSB patterns and to reduce the bitrate on near-silence.

gcp authored 12 years ago and Gregory Maxwell committed 12 years ago

Add more MSVC files to .gitignore.
Make all configurations use default floating point model.

When libopus is forced to sufficiently low rates it will start
outputting 'PLC' (one byte) frames. The code that did this
did not sanitize the mode well enough and would create corrupted
TOC values in some cases.

gcp authored 12 years ago and Gregory Maxwell committed 12 years ago

Also make the 64-bit builds use the default output directories.
Fix the type of the default Opus output to be a library.

gcp authored 12 years ago and Gregory Maxwell committed 12 years ago

The (non-default) temporary & output dirs configured in the projects could
cause issues when doing compilation on a multiprocessor machine. Cleaned
this up a little to use the defaults, which makes that work again and
doesn't make the output structure any worse. Also removed debug output for
release binaries & a tiny whitespace fix.